This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/9] ldbl-128ibm-compat: Create libm-alias-float128.h
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Tulio Magno Quites Machado Filho <tuliom at linux dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>, <gabriel at inconstante dot eti dot br>, <raji at linux dot ibm dot com>
- Date: Wed, 6 Jun 2018 23:05:08 +0000
- Subject: Re: [PATCH 1/9] ldbl-128ibm-compat: Create libm-alias-float128.h
- References: <20180606223909.16675-1-tuliom@linux.ibm.com> <20180606223909.16675-2-tuliom@linux.ibm.com>
On Wed, 6 Jun 2018, Tulio Magno Quites Machado Filho wrote:
> + __f32addieee128;
> + __f32divieee128;
> + __f32mulieee128;
> + __f32subieee128;
> + __f64addieee128;
> + __f64divieee128;
> + __f64mulieee128;
> + __f64subieee128;
> + __f64xaddieee128;
> + __f64xdivieee128;
> + __f64xmulieee128;
> + __f64xsubieee128;
The __f64x* functions shouldn't be needed here.
The __f32* and __f64* ones seem appropriate (for faddl / daddl etc.
redirection), but in patch 8 you appear to be redirecting instead to the
f32* / f64* functions (only reserved in TS 18661-3, not in TS 18661-1).
> + __gamma_productieee128;
__gamma_product is an internal part of libm, not a public exported
function. You should start from the *f128 functions that are actually
exported from libm, and justify any additions to that set carefully
(generally as functions that are part of the long double API and so need
*ieee128 versions).
> + __lgamma_negieee128;
> + __lgamma_productieee128;
Again, these are internal implementation details, not exported functions.
> + __x2y2m1ieee128;
Likewise.
--
Joseph S. Myers
joseph@codesourcery.com