This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] powerpc64le: Fix TFtype in sqrtf128 when using -mabi=ieeelongdouble


"Gabriel F. T. Gomes" <gabriel@inconstante.eti.br> writes:

> On Mon, 28 May 2018, Tulio Magno Quites Machado Filho wrote:
>
>>	* sysdeps/powerpc/powerpc64le/fpu/e_sqrtf128.c
>                           ~~~~~~~~~~~
> Missing the slash, i.e.: powerpc64/le.

Oops.  This was outdated.

>>--- a/sysdeps/powerpc/powerpc64/le/fpu/e_sqrtf128.c
>>+++ b/sysdeps/powerpc/powerpc64/le/fpu/e_sqrtf128.c
>>@@ -26,9 +26,12 @@
>>    License along with the GNU C Library; if not, see
>>    <http://www.gnu.org/licenses/>.  */
>> 
>>-/* Unavoidable hacks since TFmode is assumed to be binary128. */
>>-#define TFtype KFtype
>>-#define TF KF
>>+/* Unavoidable hacks since TFmode is assumed to be binary128 when
>>+   -mabi=ibmlongdouble is used.  */
>>+#if __HAVE_FLOAT128_UNLIKE_LDBL
>
> Don't you have to include bits/floatn.h to get the definition of
> __HAVE_FLOAT128_UNLIKE_LDBL?

Indeed.

Fixed and pushed as 1c09524e4d.

Thanks!

-- 
Tulio Magno


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]