This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Fix BZ 23187 -- stack overflow for many Phdr[]s
- From: Paul Pluzhnikov <ppluzhnikov at google dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: Florian Weimer <fw at deneb dot enyo dot de>, GLIBC Devel <libc-alpha at sourceware dot org>, DJ Delorie <dj at redhat dot com>
- Date: Sat, 2 Jun 2018 13:30:02 -0700
- Subject: Re: [patch] Fix BZ 23187 -- stack overflow for many Phdr[]s
- References: <CALoOobMmpZyrAsXqKrLuvO+c1Et88Cq6Kb2rY8N76NA5ihmCYA@mail.gmail.com> <b329fbbf-1578-2b1e-d9ba-fdb4ef5021ae@linaro.org> <87o9h7bfp1.fsf@mid.deneb.enyo.de> <0c2c968a-9c00-f6ea-9d02-61d02c507759@linaro.org> <87k1rvb8xz.fsf@mid.deneb.enyo.de> <193a712d-9387-2f95-c21f-256b431f6ebb@linaro.org>
On Fri, May 25, 2018 at 1:05 PM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
> On 22/05/2018 19:51, Florian Weimer wrote:
> > * Adhemerval Zanella:
> >
> >> At least for this specific usage where only there is only DYARRAY_resize
> >> operation it works (no regression on glibc testcase), although I am not
> >> sure it is the best way to accomplish it. How hard would adapt dl-minimal.c
> >> malloc to work with dynarray?
> >
> > DJ posted a patch:
> >
> > https://patchwork.sourceware.org/patch/21325/
> >
> > We have some disagreement regarding chunk coalescing, but this alone
> > probably should not block acceptance of the patch.
> >
> > My original use case evaporated when I realized that we can't use the
> > dl-minimal malloc during relocation, at least not under the
> > malloc/free names because relocation itself changes which functions
> > are called.
>
> I will review this patch and I think we can proceed once it is upstream
> (I take it should not have any real blocker based on your message).
I am sorry, but I got very confused by the status of this thread/patch.
I think all agree that using dynarray would be much better here.
Am I therefore to wait for DJ's patch to land? The discussion on it
appears to have stopped last August.
I don't think there is any particular hurry to handle this (BZ 23187,
very abnormal) test case, but I'd like to have a completion time
horizon that is not measured in years :-)
Thanks!
--
Paul Pluzhnikov