This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix Linux fcntl OFD locks for non-LFS architectures (BZ#20251)


On 01/06/2018 18:48, Adhemerval Zanella wrote:
>>
>> The new code calls SYSCALL_CANCEL for many more cases, some of which probably are bugs.
> 
> Indeed the F_{OFD}_GETLK* case is not the case for cancellation (since the
> lock won't be enforced by kernel).  My understanding is both POSIX and Linux
> OFD locks have similar code path which may suspend process execution (the
> case for cancellation syscall).  Do you have any reservation about making
> F_OFD_GETLK a cancellation entrypoint as well?

The questioning in fact for F_SETLK64/F_SETLKW64/F_OFD_SETLK/F_OFD_SETLKW 
(instead of F_OFD_GETLK).
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]