This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 05/12] nds32: Generic <math.h> and soft-fp Routines
- From: Vincent Chen <vincentc at andestech dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, "deanbo422 at gmail dot com" <deanbo422 at gmail dot com>, "Che-Wei Chuang (??????)" <cnoize at andestech dot com>
- Date: Fri, 1 Jun 2018 15:49:37 +0800
- Subject: Re: [PATCH v2 05/12] nds32: Generic <math.h> and soft-fp Routines
- References: <1527677142-10406-1-git-send-email-vincentc@andestech.com> <1527677142-10406-6-git-send-email-vincentc@andestech.com> <alpine.DEB.2.20.1805312143170.10808@digraph.polyomino.org.uk>
On Fri, Jun 01, 2018 at 05:44:18AM +0800, Joseph Myers wrote:
> On Wed, 30 May 2018, Vincent Chen wrote:
>
> > + FE_TONEAREST =
> > +#define FE_TONEAREST 1
> > + FE_TONEAREST,
> > + };
>
> As noted in RISC-V port review, C90 / C++98 don't support trailing commas
> in enum definitions, so you shouldn't have a comma after the last element
> of an enum defined in an installed header.
>
OK, I will remove the comma in the next version patch.
Thanks for your comment.
> --
> Joseph S. Myers
> joseph@codesourcery.com