This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] math: Merge strtod_nam_*.h into math-type-macros-*.h
- From: Rafal Luzynski <digitalfreak at lingonborough dot com>
- To: Florian Weimer <fw at deneb dot enyo dot de>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 17 May 2018 13:05:21 +0200 (CEST)
- Subject: Re: [PATCH] math: Merge strtod_nam_*.h into math-type-macros-*.h
- References: <1115228950.6898.1526508125382@poczta.nazwa.pl> <877eo2x0ak.fsf@mid.deneb.enyo.de>
- Reply-to: Rafal Luzynski <digitalfreak at lingonborough dot com>
17.05.2018 08:29 Florian Weimer <fw@deneb.enyo.de> wrote:
> [...]
> math: Reverse include order in <math-type-macros-*.h>
>
> _Float128 is defined for certain compilers indirectly from
> <libm-alias-double.h>, and <ieee754_float128.h> (included from
> <math-nan-payload-float128.h>) needs this definition.
>
> 2018-05-17 Florian Weimer <fweimer@redhat.com>
>
> * sysdeps/generic/math-type-macros-double.h: Include
> <math-nan-payload-double.h> after <libm-alias-double.h>.
> * sysdeps/generic/math-type-macros-float.h: Include
> <math-nan-payload-float.h> after <libm-alias-float.h>.
> * sysdeps/generic/math-type-macros-float128.h: Include
> <math-nan-payload-float128.h> after <libm-alias-float128.h>.
> * sysdeps/generic/math-type-macros-ldouble.h: Include
> <math-nan-payload-ldouble.h> after <libm-alias-ldouble.h>.
> [...]
Thank you, Florian. I confirm that it applies cleanly and compiles
on x86_64. I have not yet complete the test (make check) due
to the lack of time. But I believe it will complete successfully.
Please proceed with the commit.
Reviewed-by: Rafal Luzynski <digitalfreak@lingonborough.com>