This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] x86-64: remove duplicate line on PREFETCH_ONE_SET macro

From: Leonardo Sandoval <leonardo dot sandoval dot gonzalez at linux dot intel dot com>
To: Florian Weimer <fw at deneb dot enyo dot de>
Cc: libc-alpha at sourceware dot org, hjl dot tools at gmail dot com
Date: Wed, 16 May 2018 12:03:06 -0500
Subject: Re: [PATCH] x86-64: remove duplicate line on PREFETCH_ONE_SET macro
References: <20180515171303.11312-1-leonardo.sandoval.gonzalez@linux.intel.com> <874lj8vko6.fsf@mid.deneb.enyo.de>

On Tue, 2018-05-15 at 20:27 +0200, Florian Weimer wrote:
> * leonardo sandoval gonzalez:
> 
> > From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com
> > >
> > 
> > Tested on 64-bit AVX machine
> > 
> >        	  * sysdeps/x86_64/multiarch/memmove-vec-unaligned-
> > erms.S (MEMMOVE):
> >  	  remove duplicate line on PREFETCH_ONE_SET macro
> 
> This should be:
> 
> 	* sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S
> 	(PREFETCH_ONE_SET): Remove duplicate line.
> 
> > Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.
> > intel.com>
> 
> We don't use DCO, so this line is very misleading and should not be
> present.
> 
> Looks good otherwise.  Do you have commit access?

Florian, can someone check (perhaps you) if I now have commit access?

Leo

Follow-Ups:
- Re: [PATCH] x86-64: remove duplicate line on PREFETCH_ONE_SET macro
  - From: Florian Weimer

References:
- [PATCH] x86-64: remove duplicate line on PREFETCH_ONE_SET macro
  - From: leonardo . sandoval . gonzalez
- Re: [PATCH] x86-64: remove duplicate line on PREFETCH_ONE_SET macro
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]