This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 02/11] nds32: ABI Implementation
On Tue, May 15, 2018 at 07:32:29PM +0800, Florian Weimer wrote:
> On 05/14/2018 07:14 AM, Vincent Chen wrote:
> > On Sat, May 12, 2018 at 03:15:39PM +0800, Florian Weimer wrote:
> >> On 05/06/2018 04:41 PM, vincentc wrote:
> >>> + $r26 - $r27 are temp registers for OS - no need to save.
> >>
> >> Shouldn't you save them in case you decide to use them for a thread
> >> pointer eventually or something like that?
> >>
> >> Thanks,
> >> Florian
> >
> >
> > We do not save $r26, $r27 these two registers because these two register are
> > reserved for kernel space. In other words, these two registers shall not be used
> > in user space. Therefore, we needn't save these two registers to jmp_buf.
>
> Okay, in this case, you could update the register list at the top of the
> file. Perhaps also mention the register used for the thread pointer?
>
> Thanks,
> Florian
>
In nds32 port, the $r25 register is used for thread pointer. Thanks for your
suggestions. We will update the register list in next version patch.
Best regards
Vincent Chen