This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Move declare_mgen_finite_alias definition
On Fri, 11 May 2018, Tulio Magno Quites Machado Filho wrote:
> > I don't see any *need* for such renaming (either adding extra exported
> > function names for them, or renaming the source files). If extra exported
> > function names *are* added for them, I don't think that significantly
> > affects my point that the type-generic template machinery shouldn't be
> > used for such type-specific functions (because you can arrange for
> > libm_alias_ldouble to add those aliases when those files are built with
> > -mabi=ibmlongdouble and arrange for it to be used in ldbl-128ibm).
>
> Agreed.
>
> The question is: assuming you concluded you need new *ibm128 symbols,
> should the changes affect everyone using ldbl-128ibm or just those using
> ieee754/ldbl-128ibm-compat?
> That's why we're using them.
They would (a) only affect ldbl-128ibm-compat (that is, configurations
adding a third long double format), (b) only be for symbols that don't
already have implementation-namespace exports (thus, not for __*l_finite
or __issignalingl, for example), and (c) be implemented, generally, via
changes to how libm_alias_ldouble macros are defined, and through the
ldbl-128ibm functions being changed to use such macros, so most functions
do not actually require wrappers in ldbl-128ibm-compat.
--
Joseph S. Myers
joseph@codesourcery.com