Re: [PATCH] Introduce --enable-math-noprivate

[Florian Weimer <fweimer at redhat dot com>]

On 05/11/2018 06:36 PM, Adhemerval Zanella wrote:
> On 11/05/2018 12:43, Florian Weimer wrote:
> > Avoid errno@GLIBC_PRIVATE if enabled.  Additional work is needed
> > to eliminate further GLIBC_PRIVATE symbol references.

> Why just not make it the default instead of adding a configure option?

This change is perhaps appropriate (especially on x86-64, where a 
function call and indirect store is more compact that an TLS offset load 
and TLS store).  However, to remove GLIBC_PRIVATE references from the 
nan* functions and from the IFUNC resolvers (which use _rtld_global_ro 
on x86-64 and ppc64le), I need to duplicate code, and I'm not sure if 
it's appropriate to do this for such a narrow feature.

(Although the IFUNC resolvers can probably made to crash due the 
relocations they contain, but I'm still hoping for a different bugfix 
for that, which should make relocations based on non-IFUNC-symbols work 
reliably in IFUNC resolvers).

Thanks,
Florian