This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: glibc 2.25 seems to have broken AddressSaniitzer Inbox x glibc x sanitizer x
- From: Zack Weinberg <zackw at panix dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>, "Carlos O'Donell" <carlos at redhat dot com>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Szabolcs Nagy <szabolcs dot nagy at arm dot com>, GNU C Library <libc-alpha at sourceware dot org>, nd <nd at arm dot com>
- Date: Wed, 9 May 2018 09:24:30 -0400
- Subject: Re: glibc 2.25 seems to have broken AddressSaniitzer Inbox x glibc x sanitizer x
- References: <CAGQ9bdyZDj6gs6G3h2gQ2UyWVMHpuYi3SU0zyJKfGDumP3hJTA@mail.gmail.com> <bb5bec42-3dad-b064-4c74-ed54a96a7149@linaro.org> <bef28268-a86b-d573-185b-146b2f6a78c5@redhat.com> <a30bf9e8-cbea-66c2-d051-2ad31aae3c9d@redhat.com> <7f3d146c-7b91-c362-fb2f-561a08c7d239@redhat.com> <c9a6f035-6212-8b85-b0ea-85e3d92ad805@linaro.org> <980b324f-e8ff-4886-763c-dd8f29a94ede@redhat.com> <2748d850-3b28-b8da-4ad4-126c1253dbe2@arm.com> <4c4eb7e6-c683-639e-04dd-898687154fba@linaro.org> <596a3496-462d-2b56-0680-2e3d67de3e63@redhat.com> <CAGQ9bdxhhYk4vRCV47sA7_y=b-xE+Rgf+LegjvdH-Tv9bqiEsg@mail.gmail.com> <CAGQ9bdzWU2yiQqUpuAN-sB=Cxvc6aQW6JEfPDih9qRtV=T0VHg@mail.gmail.com> <alpine.DEB.2.20.1805082222190.32321@digraph.polyomino.org.uk> <CAGQ9bdzwOirmESUEVAgNAg3kgVePCdqWrdmpYnz5W1UrP1P7WQ@mail.gmail.com> <f849e33f-69f6-a2fb-d604-b53011510416@redhat.com>
On Wed, May 9, 2018 at 8:14 AM, Florian Weimer <fweimer@redhat.com> wrote:
> On 05/09/2018 12:42 AM, Konstantin Serebryany wrote:
>> Our current situation is that asan (ab)uses undocumented and unsupported
>> features of
>> glibc that glibc periodically changes, and has the full right to do so.
>>
>> What I am asking for is to have a set of documented and supported features
>> that will support asan
>> and that will be tested as part of the main glibc test suite.
...
> I think these abstractions are not really helpful because they imply a
> specific implementation strategy for (dynamic) TLS which may or may not
> apply in the future.
...
> In the meantime, I agree with Joseph: We should paper over issues with the
> current approach with more testing.
I wonder how far we could get with black-box testing. If the main
glibc testsuite compiled and ran some programs with ASan enabled,
programs that just expressed variations on the theme of "this program
should work correctly under ASan instrumentation", wouldn't that
sidestep the question of how ASan should actually do what it does, but
still allow us to detect catastrophic breakage like what prompted this
discussion? It might be redundant to what a buildbot that ran the
entire testsuite under ASan instrumentation would accomplish, but it
would also not involve someone making the indefinite time commitment
involved in running a buildbot, so it might actually happen in the
near future?
zw