This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Mark _init and _fini as hidden [BZ #23145]


On Tue, May 8, 2018 at 7:52 AM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Sun, 6 May 2018, H.J. Lu wrote:
>
>> diff --git a/scripts/check-initfini.awk b/scripts/check-initfini.awk
>> new file mode 100644
>> index 0000000000..e4a2355e02
>> --- /dev/null
>> +++ b/scripts/check-initfini.awk
>> @@ -0,0 +1,45 @@
>> +# This awk script expects to get command-line files that are each
>> +# the output of 'readelf -d' on a single shared object.
>> +# It exits successfully (0) if none contained any TEXTREL markers.
>> +# It fails (1) if any did contain a TEXTREL marker.
>> +# It fails (2) if the input did not take the expected form.
>
> This comment is clearly inapplicable to this file, since this test is not

Fixed.

> about TEXTREL, and you need a copyright / license notice on this file.
>

check-initfini.awk is based on check-textrel.awk which doesn't have
a copyright / license notice.  What should I put in check-initfini.awk?



-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]