This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [[PATCH RFC 2] 02/63] Y2038: add function __difftime64
- From: Paul Eggert <eggert at cs dot ucla dot edu>
- To: Florian Weimer <fweimer at redhat dot com>, Albert ARIBAUD <albert dot aribaud at 3adev dot fr>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 2 May 2018 12:07:32 -0700
- Subject: Re: [[PATCH RFC 2] 02/63] Y2038: add function __difftime64
- References: <20180418201819.15952-1-albert.aribaud@3adev.fr> <20180418201819.15952-2-albert.aribaud@3adev.fr> <20180418201819.15952-3-albert.aribaud@3adev.fr> <0a04fc43-9e92-1bbc-843d-049d1026d971@cs.ucla.edu> <20180419150411.4d7ee629@athena> <34e2461c-5da4-181d-d34b-b63c7f89dbf6@cs.ucla.edu> <20180502092209.540847ad@athena> <1a4c2101-130f-79bd-71ff-3393c42c000e@redhat.com>
On 05/02/2018 12:46 AM, Florian Weimer wrote:
Yes, you can simplify the code if you want, assuming that time_t
doesn't have padding bits, and even hard-code the matching unsigned type.
The simplified code is already in difftime.c. All he needs to do is to
compile difftime.c with the right flags, and perhaps make some trivial
changes to it that won't affect its current use.
I'd be more impressed by his request to rewrite the code from scratch if
his attempt to do so hadn't been so buggy. Really, we'll all be better
off using the code we already have, as that code should work in this new
environment with only trivial changes, and we can then focus on what our
main problem is rather than have to delve back into the intricacies of
time_t arithmetic and calendars and whatnot.