On 04/05/2018 06:14 PM, Andreas Schwab wrote:
On Apr 05 2018, Stefan Liebler <stli@linux.vnet.ibm.com> wrote:
Why do we need the strncpy at all?
if (len == 0 && ...)
That's obviously a typo.
Andreas.
Yes. You are right. Please have a look at the applied patch.
If the zero-termination is needed, numstr is copied to the buffer with
strncpy and the zero-termination is applied.
If numstr is either 0 bytes long or the length of the numstr string is
0, then _nss_nisplus_parse_pwent returns with 0.
This solves the mentioned warning with if build with gcc-head and
--enable-obsolete-nsl.
But I can not test it as I don't have a nisplus setup.
Bye.
Stefan