This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [[PATCH RFC 2] 10/63] Y2038: implement 64-bit-time __mktime64() and timelocal()


On Wed, 18 Apr 2018, Albert ARIBAUD (3ADEV) wrote:

> __mktime64 is designed similar to mktime, including checks on (64-bit)
> integer limits, and respects the same Posix requirements as __mktime does,
> i.e. calls tzset().

As per comments on previous versions of these patches, such duplication of 
large, complicated pieces of code must be avoided; you want a main 
function that uses the 64-bit types and the 32-bit function should be a 
simple wrapper around it.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]