This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC PATCH V2 02/10] C-SKY: TLS support

From: Joseph Myers <joseph at codesourcery dot com>
To: Mao Han <han_mao at c-sky dot com>
Cc: <libc-alpha at sourceware dot org>, <c-sky_gcc_upstream at c-sky dot com>, <gnu-csky at mentor dot com>
Date: Tue, 17 Apr 2018 20:50:03 +0000
Subject: Re: [RFC PATCH V2 02/10] C-SKY: TLS support
References: <cover.1523169833.git.han_mao@c-sky.com> <4b02034496617cddcca1a9443ac1a990d5b77710.1523169833.git.han_mao@c-sky.com>

On Sun, 8 Apr 2018, Mao Han wrote:

> +/* Default to an executable stack.  PF_X can be overridden if PT_GNU_STACK is
> + * present, but it is presumed absent.  */
> +#define DEFAULT_STACK_PERMS (PF_R|PF_W|PF_X)

This is not an appropriate default for a new port.  (Of course you need to 
fix your kernel port accordingly so it doesn't default to an executable 
stack either.)

Also, globally in the port, no leading '*' on second and subsequent lines 
of comments.

-- 
Joseph S. Myers
joseph@codesourcery.com

Follow-Ups:
- Re: [RFC PATCH V2 02/10] C-SKY: TLS support
  - From: Mao Han

References:
- [RFC PATCH V2 00/10] port C-SKY to glibc
  - From: Mao Han
- [RFC PATCH V2 02/10] C-SKY: TLS support
  - From: Mao Han

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]