Re: [PATCH 2/2] crypt.3, encrypt.3: Add notes about _XOPEN_CRYPT.

[Florian Weimer <fweimer at redhat dot com>]

On 04/17/2018 03:25 PM, Nikos Mavrogiannopoulos wrote:
> On Sat, Apr 14, 2018 at 9:56 PM, Florian Weimer <fweimer@redhat.com> wrote:
> > On 04/14/2018 09:11 PM, Nikos Mavrogiannopoulos wrote:
> > >    What about the second part of the suggestion. The crypt.3 manpage
> > > currently suggests including <unistd.h>, with _XOPEN_SOURCE defined,
> > > and that does not work with current glibc.
> >
> >
> > Current Fedora glibc.  We need to align the Fedora behavior with upstream
> > again, either by lobbying for an upstream change, or changing Fedora back to
> > how things were before.
>
> Zack mentions reasons that crypt.h is already in use, and glibc itself
> is already documenting the use of crypt.h instead of unistd.h [0].
> uclibc also provides crypt.h [1]. Wouldn't that be a sufficient reason
> to make the manpage document crypt.h as primary?

If it's just about changing the recommendation, then I'm fine with that. 
 But we don't know yet how things will turn out upstream, so spelling 
out *why* <crypt.h> is preferable would still be tricky.

Thanks,
Florian