This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] manual: Various fixes to the mbstouwcs example
On Apr 05 2018, Florian Weimer <fweimer@redhat.com> wrote:
> @@ -7,22 +8,46 @@
> wchar_t *
> mbstouwcs (const char *s)
> {
> - size_t len = strlen (s);
> - wchar_t *result = malloc ((len + 1) * sizeof (wchar_t));
> + /* Include the NUL terminator in the conversion. */
> + size_t len = strlen (s) + 1;
> + wchar_t *result = reallocarray (NULL, len + 1, sizeof (wchar_t));
I still think that result[len] is never used. The conversion of a
multibyte string with len bytes can generate at most len wide
characters.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."