This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] powerpc: Expose VSX feature test
- From: Nathan Phillips <waic9e at protonmail dot com>
- To: Tulio Magno Quites Machado Filho <tuliom at linux dot ibm dot com>
- Cc: "libc-alpha\\@sourceware.org" <libc-alpha at sourceware dot org>
- Date: Wed, 28 Mar 2018 09:45:59 -0400
- Subject: Re: [PATCH] powerpc: Expose VSX feature test
- Feedback-id: pIMM7SjgsBkoh1VHiFjtO1aCnt3hdIguBtsk5guUZVvO7OljEshi__TzlKj4CrF76xqm0sJcB-O9Syj4wMI1Lg==:Ext:ProtonMail
- References: <klDQRjHsGNLyUfoTY_7IVfFKRRAhSEeHVIYr89lVsb-ufm0FM5_KS2Wok7jCSBaVZXDYTJFmlGNMT7uJxbt0dIyn3m2SLuzdyWsoALd0pi4=@protonmail.com> <87r2o42y5f.fsf@linux.ibm.com>
- Reply-to: Nathan Phillips <waic9e at protonmail dot com>
Thank you for reviewing. Well noted about the double spaces.
On March 28, 2018 6:16 AM, Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com> wrote:
> Can't you take it directly from the hwcap variable that is already available
> when using libc_ifunc or libc_ifunc_redirected? e.g.
> sysdeps/powerpc/powerpc64/multiarch/memcmp.c
I hadn't seen that, and it makes sense.
The x86 version seems to store everything in cpu_features, then
use that to resolve the ifunc. But I see the pattern is different
in the PPC section.
I propose dropping this patch and I can follow the PPC pattern instead.