This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Use libc_hidden_* for atoi (bug 15105)
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 26 Feb 2018 10:09:31 -0800
- Subject: Re: Use libc_hidden_* for atoi (bug 15105)
- Authentication-results: sourceware.org; auth=none
- References: <alpine.DEB.2.20.1802212323470.22339@digraph.polyomino.org.uk>
On Wed, Feb 21, 2018 at 3:24 PM, Joseph Myers <joseph@codesourcery.com> wrote:
> Continuing the fixes for localplt test failures with -Os arising from
> functions not being inlined in that case, this patch fixes such
> failures for atoi by using libc_hidden_proto and libc_hidden_def.
>
> Tested for x86_64 (both that it removes this particular localplt
> failure for -Os - but other such failures remain so the bug can't yet
> be closed - and that the testsuite continues to pass without -Os).
>
> 2018-02-21 Joseph Myers <joseph@codesourcery.com>
>
> [BZ #15105]
> * stdlib/atoi.c (atoi): Use libc_hidden_def.
> * include/stdlib.h [!_ISOMAC] (atoi): Use libc_hidden_proto.
>
> diff --git a/include/stdlib.h b/include/stdlib.h
> index 5974fb3..114e12d 100644
> --- a/include/stdlib.h
> +++ b/include/stdlib.h
> @@ -210,6 +210,8 @@ libc_hidden_proto (strtoll)
> libc_hidden_proto (strtoul)
> libc_hidden_proto (strtoull)
>
> +libc_hidden_proto (atoi)
> +
> extern float __strtof_nan (const char *, char **, char);
> extern double __strtod_nan (const char *, char **, char);
> extern long double __strtold_nan (const char *, char **, char);
> diff --git a/stdlib/atoi.c b/stdlib/atoi.c
> index a6c3f1d..c428584 100644
> --- a/stdlib/atoi.c
> +++ b/stdlib/atoi.c
> @@ -26,3 +26,4 @@ atoi (const char *nptr)
> {
> return (int) strtol (nptr, (char **) NULL, 10);
> }
> +libc_hidden_def (atoi)
>
LGTM.
Thanks.
--
H.J.