This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH v2] intl/tst-gettext: fix failure with newest msgfmt
On 2018-02-08 16:39, Zack Weinberg wrote:
> On Thu, Feb 8, 2018 at 4:13 PM, Aurelien Jarno <email@example.com> wrote:
> > Since upstream gettext commit d13f165b83 (msgfmt: Remove
> > POT-Creation-Date field from the header in the output.), msgfmt does not
> > copy the POT-Creation-Date field in the header entry from the po file to
> > the mo file anymore. This breaks the assumption that we can test gettext
> > by comparing each message in the po files with the corresponding string
> > return by gettext. This makes the intl/tst-gettext to fail.
> > While it would have been possible to modify the po2test.awk script to
> > also strip the line POT-Creation-Date field when creating the msgs.h
> > file, it would not work with both the old and new msgfmt.
> > Instead create a tst-gettext-de.po file from de.po by removing the
> > POT-Creation-Date line. Another alternative would be to use a static
> > tst-gettext-de.po file, but I guess the reason for using de.po is to
> > also catch issues caused by newly added strings.
> > As tst-catgets also uses msg.h, it should also be updated. Instead of
> > using the new tst-gettext-de.po file, the patch modifies xopen-msg.awk
> > to avoid creating a second catgets->intl dependency.
> LGTM, do any intl maintainers wish to comment?
Given there are no further comments, I plan to commit that over the
week-end, unless someone objects in the meantime.
Aurelien Jarno GPG: 4096R/1DDD8C9B