This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Fwd: [PATCH v2 3/5] Don't install libio.h or _G_config.h.

[forwarding accidental off-list reply]

On Tue, Feb 6, 2018 at 8:50 AM, Adhemerval Zanella
<> wrote:
> On 05/02/2018 21:34, Zack Weinberg wrote:
>> In this patch, we stop installing libio.h and _G_config.h for public
>> use; necessarily, this means the public stdio.h stops including
>> libio.h.
> It looks good to me, with just a couple of nits below (which do not
> block the patch itself).

I can't promise to do any follow-up work anytime soon.

>> -#ifndef BUFSIZ
>> -# define BUFSIZ _IO_BUFSIZ
>> -#endif
>> +#define BUFSIZ 8192
> I think a possible subsqueuent cleanup is to remove _IO_BUFSIZE utilization
> within glibc as well.
>> +/* The value returned by fgetc and similar functions to indicate the
>> +   end of the file.  */
>> +#define EOF (-1)
> EOF is being define on both libio/libioP.h and libio/stdio.h. Shouldn't we
> cleanup the libioP.h one?

These are good suggestions for further cleanups but I'm not going to
fold them into this patchset.  I don't think there's any danger of
them getting forgotten about; whoever next looks at libio(P).h is
going to be looking for cleanups.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]