This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 1/5] Pre-cleanup: Remove unnecessary redefinitions of std symbols.

From: Joseph Myers <joseph at codesourcery dot com>
To: Zack Weinberg <zackw at panix dot com>
Cc: <libc-alpha at sourceware dot org>, <fweimer at redhat dot com>
Date: Mon, 5 Feb 2018 23:50:11 +0000
Subject: Re: [PATCH v2 1/5] Pre-cleanup: Remove unnecessary redefinitions of std symbols.
Authentication-results: sourceware.org; auth=none
References: <cover.1517872307.git.zackw@panix.com> <e919a51368f17eaf8d20bb82a2831c790c8b5e19.1517872307.git.zackw@panix.com>

On Mon, 5 Feb 2018, Zack Weinberg wrote:

> Two files in stdio-common were unnecessarily redefining some standard
> symbols as their _IO_ aliases, which causes problems for a build with
> the visibility of libio.h reduced.
> 
> This changes installed stripped libraries, because the line numbering
> changes in vfprintf.c, which changes the messages associated with a
> bunch of assertions.  However, if it weren't entangled with a scary
> change I wouldn't be hesitating to call it an obvious cleanup.
> 
> 	* stdio-common/vfprintf.c: Don't redefine FILE, va_list, or BUFSIZ.
>         * stdio-common/tstgetln.c: Don't redefine ssize_t.

OK, please commit.

-- 
Joseph S. Myers
joseph@codesourcery.com

References:
- [PATCH v2 0/5] Don't install libio.h or _G_config.h.
  - From: Zack Weinberg
- [PATCH v2 1/5] Pre-cleanup: Remove unnecessary redefinitions of std symbols.
  - From: Zack Weinberg

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]