This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] i386: Use __glibc_likely/__glibc_likely in dl-machine.h
- From: Zack Weinberg <zackw at panix dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 5 Feb 2018 15:23:08 -0500
- Subject: Re: [PATCH] i386: Use __glibc_likely/__glibc_likely in dl-machine.h
- Authentication-results: sourceware.org; auth=none
- References: <20180205122807.GA12157@gmail.com>
On Mon, Feb 5, 2018 at 7:28 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> The differences in elf/dl-reloc.os are
>
> --- before 2018-02-05 03:53:31.970492246 -0800
> +++ after 2018-02-05 03:53:49.719902340 -0800
> @@ -1202,9 +1202,9 @@ _dl_relocate_object:
> movl -60(%ebp), %eax
> testl %eax, %eax
> je .L249
> - movl 8(%eax), %eax
> - movl 8(%ebx), %esi
> - cmpl %esi, %eax
> + movl 8(%eax), %esi
> + movl 8(%ebx), %eax
> + cmpl %eax, %esi
Since __glibc_(un)likely just expand back to __builtin_expect, why are
there any assembly differences at all?