This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Don't install libio.h or _G_config.h

On Mon, 5 Feb 2018, Zack Weinberg wrote:

> On Mon, Feb 5, 2018 at 9:10 AM, Joseph Myers <> wrote:
> > On Mon, 5 Feb 2018, Zack Weinberg wrote:
> >
> >> Also, when not optimizing (specifically, if bits/stdio.h is not
> >> included) FILE will be an incomplete type.
> >
> > Before C11, FILE is required to be a complete type (because it's required
> > to be an object type, which did not include incomplete types before C11).
> Good catch, I will fix that locally.  Do you think you will have time
> for a complete review in the near future?

Is this a patch that you would expect not to result in any changes to 
installed stripped shared libraries (or if not, is there a simple way to 
separate small changes that affect installed stripped shared libraries in 
insubstantial ways from large changes that don't affect them at all)?  
The review is certainly a lot simpler if it can be mainly "are the changes 
to the exposed interfaces appropriate?" and "is the implementation 
approach appropriate?" without having "could this unexpectedly break 
something within glibc, that isn't well-tested, for some glibc 

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]