This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [hurd,commited 1/3] hurd: Fix building libio/tst-memstream3.c
On Sun, 28 Jan 2018, Samuel Thibault wrote:
> FWRITE is already an fcntl.h macro.
>
> * libio/tst-memstream3.c (FWRITE): Rename to _FWRITE.
> (do_test_bz20181): Rename accordingly.
> * libio/tst-wmemstream3.c (FWRITE): Rename accordingly.
I think we should leave the testcase using FWRITE (and certainly not make
tests use reserved-namespace names with leading '_' if it can be avoided),
and instead remove the FREAD and FWRITE macros from the generic and Hurd
bits/fcntl.h.
(There's a case for removing all the F* aliases for O_* from all
bits/fcntl.h variants, as one of many likely obsolete __USE_MISC APIs, but
that would need more investigation of how widely used they might be.
Removal of names that only appear in the Hurd-specific and (currently
unused) generic headers is pretty safe, however.)
--
Joseph S. Myers
joseph@codesourcery.com