This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix integer overflows in internal memalign and malloc functions [BZ #22343]
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>, Arjun Shankar <arjun dot is at lostca dot se>, libc-alpha at sourceware dot org
- Cc: Paul Eggert <eggert at cs dot ucla dot edu>
- Date: Wed, 17 Jan 2018 13:45:37 -0800
- Subject: Re: [PATCH] Fix integer overflows in internal memalign and malloc functions [BZ #22343]
- Authentication-results: sourceware.org; auth=none
- References: <20180117202641.GA58783@aloka.lostca.se> <eb6b17ee-6101-74d0-dc57-e0df6ba81c89@redhat.com>
On 01/17/2018 12:52 PM, Florian Weimer wrote:
> On 01/17/2018 09:26 PM, Arjun Shankar wrote:
>> +#define TIMEOUT 5
>
> The default timeout is 20 seconds (scaled by the timeout factor), so this reduces the timeout to one fourth of the default value. I think you should remove this.
>
> (I haven't looked at the other parts of the patch.)
support/test-driver.h: DEFAULT_TIMEOUT = 20,
You are absolutely right, I thought the default was 2 seconds, but
that's just my age showing... the old test-skeleton.c had a 2 second
timeout. That has changed to 20 seconds with the new support framework.
--
Cheers,
Carlos.