This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] nptl: Open libgcc.so with RTLD_NOW during pthread_cancel

From: Carlos O'Donell <carlos at redhat dot com>
To: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
Date: Wed, 10 Jan 2018 12:21:27 -0800
Subject: Re: [PATCH] nptl: Open libgcc.so with RTLD_NOW during pthread_cancel
Authentication-results: sourceware.org; auth=none
References: <20180110104903.A4F88439942E1@oldenburg.str.redhat.com> <c5dbae0e-18ec-8f76-061b-3436b55b4de7@redhat.com> <f7bab1f7-746f-cda3-928c-caa565802f2e@redhat.com> <0e8290f2-4c7f-2d1e-1bdd-09f6d4770947@redhat.com> <27824c97-0aa6-4dd3-9efb-832a678b2ebd@redhat.com>

On 01/10/2018 12:03 PM, Florian Weimer wrote:
> On 01/10/2018 08:29 PM, Carlos O'Donell wrote:
> 
>> What I want to avoid is two similar pieces of code that do distinct
>> things. Is there any reason we shouldn't just checkin a change here
>> that makes both the same, thus avoiding differences?
> 
> Okay, then let's add a comment.

Perfect. LGTM.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

-- 
Cheers,
Carlos.

References:
- [PATCH] nptl: Open libgcc.so with RTLD_NOW during pthread_cancel
  - From: Florian Weimer
- Re: [PATCH] nptl: Open libgcc.so with RTLD_NOW during pthread_cancel
  - From: Carlos O'Donell
- Re: [PATCH] nptl: Open libgcc.so with RTLD_NOW during pthread_cancel
  - From: Florian Weimer
- Re: [PATCH] nptl: Open libgcc.so with RTLD_NOW during pthread_cancel
  - From: Carlos O'Donell
- Re: [PATCH] nptl: Open libgcc.so with RTLD_NOW during pthread_cancel
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]