This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/4] Add test for getrlimit/setrlimit/prlimit with infinity value


On 2018-01-05 11:58, Adhemerval Zanella wrote:
> 
> 
> On 05/01/2018 11:24, Aurelien Jarno wrote:
> > Add a test to check that the getrlimit, setrlimit and prlimit functions
> > and their 64-bit equivalent behave correctly with RLIM_INFINITY and
> > RLIM64_INFINITY. For that it assumes that the prlimit64 function calls
> > the syscall directly without translating the value and that the kernel
> > uses the -1 value to represent infinity.
> > 
> > It first finds a resource with the hard limit set to infinity so the
> > soft limit can be manipulated easily and check for the consistency
> > between the value set or get by the prlimit64 and the other functions.
> > 
> > It is Linux specific add it uses the prlimit and prlimit64 functions.
> > 
> > Changelog:
> > 	* sysdeps/unix/sysv/linux/tst-rlimit-infinity.c: New file.
> > 	* sysdeps/unix/sysv/linux/Makefile (tests): Add tst-rlimit-infinity.
> 
> LGTM with two remarks below.
> 
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>

Thanks for the review, I'll the two issues that before committing.

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]