This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 04/15] RISC-V: Thread-Local Storage Support

From: Palmer Dabbelt <palmer at dabbelt dot com>
To: joseph at codesourcery dot com
Cc: libc-alpha at sourceware dot org, Andrew Waterman <andrew at sifive dot com>, Darius Rad <darius at bluespec dot com>, dj at redhat dot com
Date: Sat, 23 Dec 2017 11:10:50 -0800 (PST)
Subject: Re: [PATCH v2 04/15] RISC-V: Thread-Local Storage Support
Authentication-results: sourceware.org; auth=none

On Wed, 20 Dec 2017 08:45:46 PST (-0800), joseph@codesourcery.com wrote:

On Tue, 19 Dec 2017, Palmer Dabbelt wrote:

+#define thread_offsetof(mem)	(long)(offsetof(struct pthread, mem) - TLS_TCB_OFFSET - TLS_PRE_TCB_SIZE)


Missing space between offsetof and '('.

+register void* __thread_self asm("tp");


Missing space after asm.  Also should be "void *__thread_self" not "void*
__thread_self".


Thanks, these have been fixed.

References:
- Re: [PATCH v2 04/15] RISC-V: Thread-Local Storage Support
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]