This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Improve math_errhandling
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, nd <nd at arm dot com>
- Date: Thu, 21 Dec 2017 20:41:09 +0000
- Subject: Re: [PATCH] Improve math_errhandling
- Authentication-results: sourceware.org; auth=none
- References: <HE1PR0801MB2058FC670374E87D486379C783560@HE1PR0801MB2058.eurprd08.prod.outlook.com>,<alpine.DEB.2.20.1711081643590.11470@digraph.polyomino.org.uk> <DB6PR0801MB205381D0194B7BE04BBAD5CD830D0@DB6PR0801MB2053.eurprd08.prod.outlook.com>
On Thu, 21 Dec 2017, Wilco Dijkstra wrote:
> OK, setting to 0 for __FAST_MATH__ seems reasonable. Here is the revised patch:
>
> Currently math_errhandling is always set to MATH_ERRNO | MATH_ERREXCEPT
> even if -fno-math-errno is used. It is not defined at all when fast-math
> is used. Set it to 0 with fast-math - this is noncomforming but more
> useful than not define math_errhandling at all. Also take __NO_MATH_ERRNO__
> into account and update comment.
>
> ChangeLog:
> 2017-12-21 Wilco Dijkstra <wdijkstr@arm.com>
>
> * math/math.h (math_errhandling): Add __NO_MATH_ERRNO__ check.
This patch is OK.
--
Joseph S. Myers
joseph@codesourcery.com