This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/3] New generic sincosf

From: "H.J. Lu" <hjl dot tools at gmail dot com>
To: Rajalakshmi Srinivasaraghavan <raji at linux dot vnet dot ibm dot com>
Cc: Joseph Myers <joseph at codesourcery dot com>, GNU C Library <libc-alpha at sourceware dot org>
Date: Sat, 16 Dec 2017 06:43:23 -0800
Subject: Re: [PATCH 1/3] New generic sincosf
Authentication-results: sourceware.org; auth=none
References: <1513143801-3290-1-git-send-email-raji@linux.vnet.ibm.com> <1513143801-3290-2-git-send-email-raji@linux.vnet.ibm.com> <alpine.DEB.2.20.1712150029250.5909@digraph.polyomino.org.uk> <CAMe9rOq3VHYR5prK-oHLB+YjHEJXKU8+gCU_XTsOX12n3RvcQA@mail.gmail.com> <alpine.DEB.2.20.1712151408290.3687@digraph.polyomino.org.uk> <CAMe9rOo-gR0XUuZ2oxEwMj71hukysA75XEhqmsfnx_x414ieqw@mail.gmail.com> <alpine.DEB.2.20.1712151547280.13157@digraph.polyomino.org.uk> <CAMe9rOqD=yXstUu1QZ8zBn268UsQL_iC-VxEntpYaKn_kbwcCA@mail.gmail.com> <alpine.DEB.2.20.1712151620250.13157@digraph.polyomino.org.uk> <CAMe9rOq+-Vd=VOku-gbH=xSUd00rD=Sm6MhCvD6Sf26rMJ02hg@mail.gmail.com> <CAMe9rOq6PZ17V-sMJm50Lxw8Ko+4b37fb8n6JDP_F+m8iSG-Vg@mail.gmail.com> <alpine.DEB.2.20.1712152050110.860@digraph.polyomino.org.uk> <45451ed9-df1f-ff5e-f2fd-552e705d100c@linux.vnet.ibm.com>

On Sat, Dec 16, 2017 at 12:52 AM, Rajalakshmi Srinivasaraghavan
<raji@linux.vnet.ibm.com> wrote:
>
>
> On 12/16/2017 02:20 AM, Joseph Myers wrote:
>>
>> On Fri, 15 Dec 2017, H.J. Lu wrote:
>>
>>> One comment,  should sysdeps/ieee754/flt-32/s_sincos.h be renamed
>>> to  sysdeps/ieee754/flt-32/s_sincosf.h?
>>
>>
>> Yes, I think so.
>>
>
> Pushed as 984ae9967b49830173490a33ae6130880f3f70d9 with the file
> name changed as s_sincosf.h.  Thanks for the review.
>

I noticed that sysdeps/x86_64/fpu/s_sincosf.S is still faster:

Generic:

    "max": 276.971,
    "min": 10.813,
    "mean": 29.3755

SSE2:

    "max": 138.795,
    "min": 11.686,
    "mean": 22.9463

The SSE2 is 28% faster.  Do they use the same algorithm?


-- 
H.J.

Follow-Ups:
- Re: [PATCH 1/3] New generic sincosf
  - From: Rajalakshmi Srinivasaraghavan

References:
- [PATCH 0/3] New generic sincosf
  - From: Rajalakshmi Srinivasaraghavan
- [PATCH 1/3] New generic sincosf
  - From: Rajalakshmi Srinivasaraghavan
- Re: [PATCH 1/3] New generic sincosf
  - From: Joseph Myers
- Re: [PATCH 1/3] New generic sincosf
  - From: H.J. Lu
- Re: [PATCH 1/3] New generic sincosf
  - From: Joseph Myers
- Re: [PATCH 1/3] New generic sincosf
  - From: H.J. Lu
- Re: [PATCH 1/3] New generic sincosf
  - From: Joseph Myers
- Re: [PATCH 1/3] New generic sincosf
  - From: H.J. Lu
- Re: [PATCH 1/3] New generic sincosf
  - From: Joseph Myers
- Re: [PATCH 1/3] New generic sincosf
  - From: H.J. Lu
- Re: [PATCH 1/3] New generic sincosf
  - From: H.J. Lu
- Re: [PATCH 1/3] New generic sincosf
  - From: Joseph Myers
- Re: [PATCH 1/3] New generic sincosf
  - From: Rajalakshmi Srinivasaraghavan

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]