This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 11/17] Regex: Remove leading __ on parameter names in

From: arnold at skeeve dot com
To: joseph at codesourcery dot com, arnold at skeeve dot com
Cc: libc-alpha at sourceware dot org, carlos at redhat dot com
Date: Fri, 08 Dec 2017 05:45:35 -0700
Subject: Re: [PATCH 11/17] Regex: Remove leading __ on parameter names in
Authentication-results: sourceware.org; auth=none
References: <201712080916.vB89Gxt5005511@skeeve.com> <alpine.DEB.2.20.1712081120400.3915@digraph.polyomino.org.uk>

Joseph Myers <joseph@codesourcery.com> wrote:

> On Fri, 8 Dec 2017, Arnold Robbins wrote:
>
> > This patch removes the leading '__' on parameter names in the
> > various function declarations in regex.h.
>
> This is an installed header and must be namespace-clean.  Unless it is 
> specifically part of the documented API for that header (much of which 
> comes from POSIX) that symbol names such as "buffer", "pattern" and 
> "length" are reserved by the header and must not be defined as macros by 
> the user before it's included, such changes are incorrect.
>
> -- 
> Joseph S. Myers
> joseph@codesourcery.com

Well, at least now I know why all those underscores are there.
I guess this one won't get merged.

Arnold

References:
- [PATCH 11/17] Regex: Remove leading __ on parameter names in
  - From: Arnold Robbins
- Re: [PATCH 11/17] Regex: Remove leading __ on parameter names in
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]