This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Linux: Introduce <bits/mman-shared.h>
On 11/24/2017 08:51 AM, Florian Weimer wrote:
> On 11/24/2017 05:49 PM, Florian Weimer wrote:
>> This header file enables sharing of portable declarations and
>> definitions across all Linux architectures, including hppa (which does
>> not use <bits/mman-linux.h>).
>>
>> 2017-11-24 Florian Weimer<fweimer@redhat.com>
>>
>> * sysdeps/unix/sysv/linux/Makefile (sysdep_headers): Add
>> bits/mman-shared.h.
>> * sysdeps/unix/sysv/linux/bits/mman-linux.h: Include
>> <bits/mman-shared.h>.
>> (MFD_CLOEXEC, MFD_ALLOW_SEALING, MFD_HUGETLB, memfd_create): Move
>> to ...
>> * sysdeps/unix/sysv/linux/bits/mman-shared.h: ... this new file.
>> Add #ifndef guard for the MFD_* constants based on MFD_CLOEXEC.
>> * sysdeps/unix/sysv/linux/hppa/bits/mman.h: Include
>> <bits/mman-shared.h>.
>>
>
> Note that I have not yet tested this on hppa, but I think I got rid of all the typos, so it should just work there.
>
> Now I have to rebase all my pending mman-related patches. 8-}
Looks good to me.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
--
Cheers,
Carlos.