This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] support: Add TEST_COMPARE macro

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Florian Weimer <fweimer at redhat dot com>, Siddhesh Poyarekar <siddhesh at gotplt dot org>, GNU C Library <libc-alpha at sourceware dot org>
Cc: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Date: Fri, 24 Nov 2017 00:46:51 -0800
Subject: Re: [PATCH] support: Add TEST_COMPARE macro
Authentication-results: sourceware.org; auth=none
References: <8d63a2dc-f9e9-acaa-5ac5-ac5c4fbd6c9f@redhat.com> <8c399cde-3093-0195-a89a-ca230540cffb@gotplt.org> <8339a519-935a-019c-4a8f-798e37f6f346@redhat.com>

It'd be cleaner and simpler to test for negative than positive integers. "boolnegative = n < 0;" extracts N's sign bit if N is signed and requires no machineinstructions if N is unsigned; "bool positive = n > 0;" is trickier.

I don't know what the context for this new macro is, and like Andreas I'm a bitpuzzled as to its intended use.

Follow-Ups:
- Re: [PATCH] support: Add TEST_COMPARE macro
  - From: Florian Weimer

References:
- [PATCH] support: Add TEST_COMPARE macro
  - From: Florian Weimer
- Re: [PATCH] support: Add TEST_COMPARE macro
  - From: Siddhesh Poyarekar
- Re: [PATCH] support: Add TEST_COMPARE macro
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]