This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] libc.so: Replace nscd_hash.os with libc-nscd_hash.os [BZ #22459]
On 11/20/2017 02:18 PM, H.J. Lu wrote:
Do we need to export it in GLIBC_2.27 space? I prefer GLIBC_PRIVATE.
Otherwise, it looks good to me.
The libnsl symbol isn't GLIBC_PRIVATE, but perhaps should have been.
You added __nss_hash to libc.abilist. Shouldn't it be in libc.so?
I can't change the libnsl symbol, and nscd won't be able to use libnsl.
I'm somewhat in favor of exporting this because independent nscd
implementations will need to implement the exact same hash function.
Do we support independent nscd implementation?
There is unscd (in the context of busybox), but it does not seem to
support the maps.
I think we should avoid
exporting non-standard internal functions in public name space. But this is
my personal opinion. If others believe it is OK, it is fine with me.
It's not really internal if we support alternative nscd implementations
with compatible mappings.
Thanks,
Florian