This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/3] benchtests: Bump start size since smaller sizes are noisy
... and now pushed.
Siddhesh
On Thursday 09 November 2017 10:43 AM, Siddhesh Poyarekar wrote:
> Numbers for very small sizes (< 128B) are much noisier for non-cached
> benchmarks like the walk benchmarks, so don't include them.
>
> * benchtests/bench-memcpy-walk.c (START_SIZE): Set to 128.
> * benchtests/bench-memmove-walk.c (START_SIZE): Likewise.
> * benchtests/bench-memset-walk.c (START_SIZE): Likewise.
> ---
> benchtests/bench-memcpy-walk.c | 2 +-
> benchtests/bench-memmove-walk.c | 2 +-
> benchtests/bench-memset-walk.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/benchtests/bench-memcpy-walk.c b/benchtests/bench-memcpy-walk.c
> index 5b56341..ef90a92 100644
> --- a/benchtests/bench-memcpy-walk.c
> +++ b/benchtests/bench-memcpy-walk.c
> @@ -29,7 +29,7 @@
>
> #ifndef MEMCPY_RESULT
> # define MEMCPY_RESULT(dst, len) dst
> -# define START_SIZE 1
> +# define START_SIZE 128
> # define MIN_PAGE_SIZE (getpagesize () + 32 * 1024 * 1024)
> # define TEST_MAIN
> # define TEST_NAME "memcpy"
> diff --git a/benchtests/bench-memmove-walk.c b/benchtests/bench-memmove-walk.c
> index 969ddd9..189ce64 100644
> --- a/benchtests/bench-memmove-walk.c
> +++ b/benchtests/bench-memmove-walk.c
> @@ -29,7 +29,7 @@
>
> #ifndef MEMMOVE_RESULT
> # define MEMMOVE_RESULT(dst, len) dst
> -# define START_SIZE 1
> +# define START_SIZE 128
> # define MIN_PAGE_SIZE (getpagesize () + 32 * 1024 * 1024)
> # define TEST_MAIN
> # define TEST_NAME "memmove"
> diff --git a/benchtests/bench-memset-walk.c b/benchtests/bench-memset-walk.c
> index 80fbe09..213bb60 100644
> --- a/benchtests/bench-memset-walk.c
> +++ b/benchtests/bench-memset-walk.c
> @@ -22,7 +22,7 @@
> #else
> # define TEST_NAME "wmemset"
> #endif /* WIDE */
> -#define START_SIZE (1)
> +#define START_SIZE 128
> #define MIN_PAGE_SIZE (getpagesize () + 32 * 1024 * 1024)
> #define TIMEOUT (20 * 60)
> #include "bench-string.h"
>