Re: [PATCH 1/3] benchtests: Wide range of tests names in schema.json

["Rodriguez Bahena, Victor" <victor dot rodriguez dot bahena at intel dot com>]

-----Original Message-----
From: Paul Clarke <pc@us.ibm.com>
Date: Thursday, November 16, 2017 at 7:12 PM
To: Victor Rodriguez Bahena <victor.rodriguez.bahena@intel.com>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Subject: Re: [PATCH 1/3] benchtests: Wide range of tests names in
schema.json

>
>
>On 11/16/2017 04:52 PM, Victor Rodriguez wrote:
>> When executing bench-math the benchmark output is invalid with this
>> error msg:
>> 
>> Invalid benchmark output: 'workload-spec2006.wrf' does not match any of
>> the regexes: '^[_a-zA-Z0-9]*$¹ or Invalid benchmark output: Additional
>> properties are not allowed ('workload-spec2006.wrf' was unexpected)
>> 
>> This patch change regex in benchout.schema.json to accept simbols in
>
>s/change/changes/
>s/simbols/symbols/
>
>> benchmark tests names
>> 
>> 	(VERSION): Set to 2.27
>>         * benchtests/scripts/benchout.schema.json: Fix regex to accept a
>>         wide range of tests names
>
>s/wide/wider/
>
>Also, should the subject be "Widen" (or "Expand"?), instead of "Wide" ?
>
>> 
>> Signed-off-by: Victor Rodriguez <victor.rodriguez.bahena@intel.com>
>> ---
>>  ChangeLog                               | 6 ++++++
>>  benchtests/scripts/benchout.schema.json | 2 +-
>>  2 files changed, 7 insertions(+), 1 deletion(-)
>> 
>> diff --git a/ChangeLog b/ChangeLog
>> index 8dbfc7e..7d0fd63 100644
>> --- a/ChangeLog
>> +++ b/ChangeLog
>> @@ -1,3 +1,9 @@
>> +2017-11-15  Victor Rodriguez  <victor.rodriguez.bahena@intel.com>
>> +
>> +	(VERSION): Set to 2.27
>> +	* benchtests/scripts/benchout.schema.json: Fix regex to accept a wide
>>range
>
>s/wide/wider/?
>
>> +	of tests names.
>> +
>>  2017-08-02  Siddhesh Poyarekar  <siddhesh@sourceware.org>
>> 
>>  	* version.h (RELEASE): Set to "stable"
>> diff --git a/benchtests/scripts/benchout.schema.json
>>b/benchtests/scripts/benchout.schema.json
>> index affb7c1..814c633 100644
>> --- a/benchtests/scripts/benchout.schema.json
>> +++ b/benchtests/scripts/benchout.schema.json
>> @@ -13,7 +13,7 @@
>>            "title": "Function names",
>>            "type": "object",
>>            "patternProperties": {
>> -            "^[_a-zA-Z0-9]*$": {
>> +            "^[_a-zA-Z0-9_,=.-]*$": {
>                  ^         ^
>It looks like '_' is there twice.

Thanks , you are right
>
>How did you come up with the set of new characters?  It would be helpful
>to include that in the patch description.

Test names like workload-spec2006.wrf break the script due to . and -

I will include that in the patch description and send V2

Regards

>
>PC
>