Re: [PATCH] malloc: Add missing arena lock in mallinfo [BZ #22408]

[DJ Delorie <dj at redhat dot com>]

Siddhesh Poyarekar <siddhesh@gotplt.org> writes:
> I don't see how you came to that conclusion, there is a fix in there
> that brings heap->size into the lock scope of ar_ptr->mutex.  That is
> one fix and the other fix is to then expand the heap traversal so that
> all heaps are accounted for.  Florian's follow-up patches have correctly
> made that split.

Florian's new patches move a line of code in one, and immediately remove
it in the second, just to satisfy a BZ.  I doubt the readers of the BZ
care about anything beyond "it was fixed" 99% of the time.

> They're two very different bugs and hence should have two different
> patches to clearly indicate what changed.

I don't feel too strongly about this because the code is the same in the
end, but it seems like extra work with a weak justification.  These are
the types of requirements that may put off a first-time contributor.
Obviously this doesn't apply to Florian ;-)