This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] posix: Make tst-getaddrinfo5 an xtest due to Internet requirement [BZ #20826]
On 11/14/2017 12:17 PM, Aurelien Jarno wrote:
> On 2017-11-13 14:22, Florian Weimer wrote:
>> We have additional coverage of getaddrinfo through the resolv tests, so
>> the loss of default test coverage seems acceptable.
>>
>> 2017-11-13 Florian Weimer <fweimer@redhat.com>
>>
>> [BZ #20826]
>> Turn posix/tst-getaddrinfo5 into xtest due to Internet requirement.
>> * posix/Makefile (tests): Remove tst-getaddrinfo5.
>> (xtests): Add tst-getaddrinfo5.
>>
>
> IMHO, this test should succeed even without network access, provided
> that /etc/hosts contains an entry for localhost, which is something
> pretty standard. However nss_files only consider exact matching, and
> doesn't consider 'localhost.' being the same as 'localhost'.
We will eventually run this test in a newtork namespace with a known
configured hosts file. Until that point I think it needs to remain an
xtest. We should not rely on the host being configured in any magical
way.
DJ is currently looking at running tests in a minimal namespace to
allow us to do exactly this kind of testing. If you have any interest
in that please reach out to DJ.
--
Cheers,
Carlos.