Re: [RFC PATCH] benchtests:Add BENCHSET list of targets

[Siddhesh Poyarekar <siddhesh at gotplt dot org>]

Thanks, the code change itself is good.  There are a couple of minor
nits below to fix that you can include in your next iteration.
Additionally, this needs documentation, so please add a note on this
option to benchtests/README describing it similar to other make variable
options in that file.

On Thursday 09 November 2017 09:24 AM, Victor Rodriguez wrote:
> This patch adds BENCHSET list of targets in order to run benchmarks as:
> 
> make bench BENCHSET="bench-pthread bench-math malloc-thread"

I suppose you meant bench-malloc-thread there.

> 
> This helps users to run benchmarks acording to the glibc area they
> are measuring.
> 
> Changelog:
> 2017-11-08  Victor Rodriguez  <victor.rodriguez.bahena@intel.com>
> 
>        (VERSION): Set to 2.26

Copy paste error? :)

>        * benchtests/Makefile:Add BENCHSET to allow subsets of benchmarks to be run

End statement with a period.

> 
> Signed-off-by: Victor Rodriguez <victor.rodriguez.bahena@intel.com>
> Signed-off-by: Icarus Sparry <icarus.w.sparry@intel.com>
> ---
>  ChangeLog           |  5 +++++
>  benchtests/Makefile | 12 ++++++++++++
>  2 files changed, 17 insertions(+)
> 
> diff --git a/ChangeLog b/ChangeLog
> index 8dbfc7e..832461c 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2017-11-08  Victor Rodriguez  <victor.rodriguez.bahena@intel.com>
> +
> +	(VERSION): Set to 2.26
> +	* benchtests/Makefile:Add BENCHSET to allow subsets of benchmarks to be run
> +
>  2017-08-02  Siddhesh Poyarekar  <siddhesh@sourceware.org>
>  
>  	* version.h (RELEASE): Set to "stable"
> diff --git a/benchtests/Makefile b/benchtests/Makefile
> index 37788e8..2bc4a25 100644
> --- a/benchtests/Makefile
> +++ b/benchtests/Makefile
> @@ -29,7 +29,11 @@ bench-pthread := pthread_once thread_create
>  
>  bench-string := ffs ffsll
>  
> +ifeq (${BENCHSET},)
>  bench := $(bench-math) $(bench-pthread) $(bench-string)
> +else
> +bench := $(foreach B,$(filter bench-%,${BENCHSET}), ${${B}})
> +endif
>  
>  # String function benchmarks.
>  string-benchset := bcopy bzero memccpy memchr memcmp memcpy memmem memmove \
> @@ -66,8 +70,12 @@ stdio-common-benchset := sprintf
>  
>  math-benchset := math-inlines
>  
> +ifeq (${BENCHSET},)
>  benchset := $(string-benchset-all) $(stdlib-benchset) $(stdio-common-benchset) \
>  	    $(math-benchset)
> +else
> +benchset := $(foreach B,$(filter %-benchset,${BENCHSET}), ${${B}})
> +endif
>  
>  CFLAGS-bench-ffs.c += -fno-builtin
>  CFLAGS-bench-ffsll.c += -fno-builtin
> @@ -77,7 +85,11 @@ CFLAGS-bench-fminf.c += -fno-builtin
>  CFLAGS-bench-fmax.c += -fno-builtin
>  CFLAGS-bench-fmaxf.c += -fno-builtin
>  
> +ifeq (${BENCHSET},)
>  bench-malloc := malloc-thread
> +else
> +bench-malloc := $(foreach B,$(filter malloc-%,${BENCHSET}), ${${B}})
> +endif
>  
>  $(addprefix $(objpfx)bench-,$(bench-math)): $(libm)
>  $(addprefix $(objpfx)bench-,$(math-benchset)): $(libm)
> 

Siddhesh