This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] add attribute nonstring
On Fri, 10 Nov 2017, Martin Sebor wrote:
> Okay, thanks. I've read that you run periodic Glibc builds with
> the latest GCC so I wanted to give you a heads up on this change
> and the patch to avoid breaking them. Unless that's not a concern
> (do you use -Werror in those builds?) what is the best way to
> coordinate this update?
The builds use -Werror, and run daily (actually more like every 30 hours
when the builds succeed, because each build starts 24 hours after the
previous one finished). The main issue with a GCC patch breaking the
build going in some time before a glibc patch fixing the build is that it
may make it harder to find what GCC patch introduced any other build
breakage that appears while there are warnings (we currently have two such
breakages with GCC mainline, for powerpc64le and sh).
The most obvious question for people to consider in reviewing this patch
(apart from getting a tzfile.h fix from upstream) is coding style: do we
want __NONSTRING on a separate line as in this patch, or on the same line
as the member declaration in question (before the type, or after the [])?
Also, sys/cdefs.h should be using __GNUC_PREREQ (8, 0), not a direct test
of __GNUC__.
--
Joseph S. Myers
joseph@codesourcery.com