Re: [PATCH v2 5/5] linux ttyname and ttyname_r: Add tests [BZ #22145]

[Luke Shumaker <lukeshu at lukeshu dot com>]

On Thu, 02 Nov 2017 14:53:46 -0400,
Luke Shumaker wrote:
> +  /* support_become_root might have put us in a new user namespace;
> +     most filesystems (including tmpfs) don't allow file or directory
> +     creation from a user namespace unless uid and gid maps are set,
> +     even if we have root privileges in the namespace (failing with
> +     EOVERFLOW, since the uid overflows the empty (0-length) uid map).
> +
> +     Also, stat always reports that uid and gid maps are empty, so we
> +     have to try actually reading from them to check if they are
> +     empty. */

Style: two spaces after the trailing period.  This mistake is
consistent throughout the file.

> +    /* Depeding on how we set up the chroot, the kernel may or may not
> +     * trim the leading path to the target (it may give us "/6",
> +     * instead of "/dev/pts/6").  This test group relies on the target
> +     * existing, so guarantee that (so create a file at "/6" if
> +     * necessary). */

Style: no '*', two spaces after the trailing period.

Andreas Schwab made me aware of these style issues on the previous
commit.

-- 
Happy hacking,
~ Luke Shumaker