This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 3/8] Filter out NPTL internal signals (BZ #22391)



On 06/11/2017 12:02, Zack Weinberg wrote:
> On Mon, Nov 6, 2017 at 8:37 AM, Adhemerval Zanella
> <adhemerval.zanella@linaro.org> wrote:
>> Changes from previous version:
>>
>>   - Use the internal-signals.h headers instead of nptl-signals.
> 
> The ChangeLog is inconsistent with the code: I spent a few minutes
> being confused because I thought the previous patch was dropping the
> __nptl prefix from these internal functions.  Which it is, and the
> code appears to be right, but the changelog doesn't match.
> 
> zw
> 

My mistake, I will fix it locally.  I changed to:

	[BZ #22391]
	* manual/signal.texi: Add a note about internal pthread signals
	on Linux.
	* sysdeps/unix/sysv/linux/alpha/sigprocmask.c: Remove file.
	* sysdeps/unix/sysv/linux/ia64/sigprocmask.c: Likewise.
	* sysdeps/unix/sysv/linux/s390/s390-64/sigprocmask.c: Likewise.
	* sysdeps/unix/sysv/linux/sparc/sparc64/sigprocmask.c: Likewise.
	* sysdeps/unix/sysv/linux/x86_64/sigprocmask.c: Likewise.
	* sysdeps/unix/sysv/linux/internal-signals.h
	(__nptl_has_internal_signal): New function.
	* sysdeps/unix/sysv/linux/sigprocmask.c (__sigprocmask):
	Use __has_internal_signal and __clear_internal_signals
	function.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]