This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 6/6] Cleanup sigpause implementation
On 05/11/2017 19:27, Zack Weinberg wrote:
> On Fri, Nov 3, 2017 at 5:40 PM, Adhemerval Zanella
> <adhemerval.zanella@linaro.org> wrote:
>> This patch simplify sigpause by remobing the single thread optimization
>> since it will be handled already by the __sigsuspend call.
>>
>> Checked on x86_64-linux-gnu.
>>
>> * sysdeps/posix/sigpause.c (do_sigpause): Remove.
>> (__sigpause): Rely on __sigsuspend to implement single thread
>> optimization.
>
> LGTM except that the addition of LIBC_CANCEL_HANDLED sent me down a
> rabbit hole - I might have to write a replacement for
> tst-cancel-wrappers.sh that doesn't depend on these magic markers -
> anyway, please mention in the ChangeLog entry that you added this
> annotation, and put /* __sigsuspend handles cancellation */
> immediately above the LIBC_CANCEL_HANDLED line, following the pattern
> of all the other uses of LIBC_CANCEL_HANDLED; that'll make things at
> least a _little_ easier for future archaeologists.
>
> zw
>
In fact with my cancellation refactor patch my idea is just remove this
fragile test which require this extra marks (since now we have now
coverage for pretty much all symbols with runtime cancellation tests).