This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 3/6] Simplify Linux sig{timed}wait{info} implementations
On 05/11/2017 19:36, Zack Weinberg wrote:
> On Fri, Nov 3, 2017 at 5:40 PM, Adhemerval Zanella
> <adhemerval.zanella@linaro.org> wrote:
>> This patch simplifies sig{timed}wait{info} by:
>>
>> - Assuming __NR_rt_sigtimedwait existence on all architectures due minimum
>> kernel version requirement.
>
> As with __NR_rt_sigqueueinfo, please document in the commit message
> the oldest kernel version that provides __NR_rt_sigtimedwait on all
> architectures.
Ack, as for __NR_rt_sigqueueinfo I will state Linux 2.6.
>
>> - Add libc.so private __sigtimedwait symbol.
>
> It is not apparent to me why this is necessary, please explain.
Now that sigwait is based on a internal sigtimedwait call and it is
present of both libc.so and libpthread.so we need to add an external
private definition for libpthread.so call.
>
>> * sysdeps/unix/sysv/linux/sigwait.c (__sigwait): Call __sigtimedwait.
>> * sysdeps/unix/sysv/linux/sigwaitinfo.c (__sigwaitinfo): Likewise.
>
> As with your sigpause/sigsuspend changes, please mention the addition
> of LIBC_CANCEL_HANDLED annotations in the ChangeLog and add /*
> __sigtimedwait handles cancellation */ comments above the
> LIBC_CANCEL_HANDLED lines.
>
> zw
>
Ack.