This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Separate patch reviews for support/ additions?
- From: DJ Delorie <dj at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 03 Nov 2017 17:54:05 -0400
- Subject: Re: Separate patch reviews for support/ additions?
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dj at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 056D583F40
Florian Weimer <fweimer@redhat.com> writes:
> Do we want separate patch reviews for any new support/ functions? Or
> should we just add them along with test cases that need them?
If the question is, "should we review new things in support/?" I think
the answer is obviously yes.
But I assume the question is, "should they be reviewed separately, or
bundled?" I prefer bundled - we have a large enough patch backlog
already without artificially increasing traffic. Also, seeing the
context might help with the review. It would certainly short-circuit
the "why do we need this?" questions ;-)