This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Reformat sysdeps/x86/libc-start.c
On 11/03/2017 02:01 PM, H.J. Lu wrote:
> On Fri, Nov 3, 2017 at 1:51 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>> Florian Weimer wrote:
>>> On 10/30/2017 11:12 PM, Jonathan Nieder wrote:
>>>> Carlos O'Donell wrote:
>>
>>>>> Should we extend consensus?
>>>>>
>>>>> https://sourceware.org/glibc/wiki/Consensus#Trivial_Bug-Fix_Changes
>>>>> ~~~
>>>>> Anyone can commit a change fixing obvious coding standards problems
>>>>> in a recently committed patch. Post the patch and ChangeLog to
>>>>> libc-alpha with a short message and then push the commit.
>>>>> ~~~
>>>>> s/a recently/any/g
>> [...]
>>>> I would rather not --- getting LGTM is a pretty lightweight action,
>>>
>>> I must say that I agree with Carlos here. Even what should be a trivial
>>> review is often difficult to get, and a lot of cleanups land only because
>>> the author eventually commits their changes without review.
>>
>> Sounds like a plan.
>>
>> I don't want to lose sight of this being a symptom of the review
>> process being broken, though. My offer to help in whatever way looks
>> most useful still stands: e.g. feel free to explicitly cc me if you
>> have an obvious change that doesn't fall into this 'coding standards'
>> category that needs review.
>
> Here is one:
>
> https://sourceware.org/ml/libc-alpha/2017-10/msg01322.html
Likewise we have a list which needs review:
https://patchwork.sourceware.org/project/glibc/list/
--
Cheers,
Carlos.