This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv2] New generic sinf
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Rajalakshmi Srinivasaraghavan <raji at linux dot vnet dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 2 Nov 2017 12:49:26 +0000
- Subject: Re: [PATCHv2] New generic sinf
- Authentication-results: sourceware.org; auth=none
- References: <1509436736-23436-1-git-send-email-raji@linux.vnet.ibm.com> <alpine.DEB.2.20.1710311832390.4581@digraph.polyomino.org.uk> <42522826-cf4a-d36e-5aac-a27d75606852@linux.vnet.ibm.com>
On Thu, 2 Nov 2017, Rajalakshmi Srinivasaraghavan wrote:
> BZ#5997 reported sinf performance on x86_64 and sinf had
> already been optimized for x86_64. The proposed patch is
> generic version which now improves performance on other
> arch. So I think 5997 can be marked as fixed.
In my view, bug 5997 reported performance issues with the generic
implementation and it simply happened that the reporter was using x86_64.
Bug reports should always be understood globally in that sense: changing
the implementation used on one platform is not a sufficient fix if the
problem implementation remains used on other platforms. (In the case of
correctness reports for libm functions it can generally be useful to
understand them to apply to all floating-point formats as well, at least
where the implementations are similar, but that doesn't really make sense
for performance reports that are very specific to the characteristics of a
particular implementation.)
--
Joseph S. Myers
joseph@codesourcery.com