This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] x86: Add sysdeps/x86/sysdep.h
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 1 Nov 2017 05:33:42 -0700
- Subject: Re: [PATCH] x86: Add sysdeps/x86/sysdep.h
- Authentication-results: sourceware.org; auth=none
- References: <20171027214205.GA17473@gmail.com>
On Fri, Oct 27, 2017 at 2:42 PM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> Add a new header file, sysdeps/x86/sysdep.h, for common assembly code
> macros bewteen i386 and x86-64. Tested on i686 and x86-64. There are
> no differences in outputs of "readelf -a" and "objdump -dw" on all glibc
> shared objects before and after the patch.
>
> Any comments?
>
> H.J.
> ---
> * sysdeps/i386/sysdep.h: Include <sysdeps/x86/sysdep.h> instead
> of <sysdeps/generic/sysdep.h>.
> (ALIGNARG): Removed.
> (ASM_SIZE_DIRECTIVE): Likewise.
> (ENTRY): Likewise.
> (END): Likewise.
> (ENTRY_CHK): Likewise.
> (END_CHK): Likewise.
> (syscall_error): Likewise.
> (mcount): Likewise.
> (PSEUDO_END): Likewise.
> (L): Likewise.
> (atom_text_section): Likewise.
> * sysdeps/x86/sysdep.h: New file.
> * sysdeps/x86_64/sysdep.h: Include <sysdeps/x86/sysdep.h> instead
> of <sysdeps/generic/sysdep.h>.
> (ALIGNARG): Removed.
> (ASM_SIZE_DIRECTIVE): Likewise.
> (ENTRY): Likewise.
> (END): Likewise.
> (ENTRY_CHK): Likewise.
> (END_CHK): Likewise.
> (syscall_error): Likewise.
> (mcount): Likewise.
> (PSEUDO_END): Likewise.
> (L): Likewise.
> (atom_text_section): Likewise.
I am checking it in.
--
H.J.